Jonathan Kemp

Results 128 comments of Jonathan Kemp

The PR was never made. I wasn't aware of this fork. My comments above are still valid.

Could be an issue with gulp-useref internally but not one that is currently known or easily fixed.

Yes, I would prefer not to use Promises here.

I need more information here. The failing test in #185 passes once the file is added back to the stream. That seems to invalidate this claim that it is timing...

I don't see this as a huge problem that needs solving. This is the first time I've ever had this complaint. I do think additional docs could help though, like...

I'm afraid I don't understand the problem this should solve.

This would be an issue for the https://github.com/digisfera/useref repo. However, https://github.com/taptapship/wiredep might be an alternative solution that would work.

@eugenekgn my guess is this doesn't work because the comments are stripped out. Can you confirm this?

Try setting the url to the path of the file: `options.url = 'file://' + file.path;`.