Jonathan Kemp

Results 128 comments of Jonathan Kemp
trafficstars

It would need to be converted into the UMD format for that to work. It doesn't support that currently. I don't use browserfy so I'm not familiar with why that...

@madmanlear are there any open issues which this pull request is addressing?

@madmanlear if you don't mind, that would be helpful. Even if it's just one.

@madmanlear thanks. Can you actually split this into two pull requests, one for each feature? Tests would be good as well.

Not at the moment. I will consider it though when I have some time. It would be helpful if you were more specific about what you would like to see.

I don't know enough about this to propose a solution, so I'm open to suggestions or pull requests even.

> Shouldn't the expected output remove the inline style and replace it with an equivalent class? No, but it should be outputting the CSS. > Any idea what might be...

> does the module remove the inlined CSS from HTML No > I did try to run the above script on my laptop, same output. Did you get any errors?...

Ok, I'll accept the possibility that you are right and the docs are wrong and it doesn't extract inline css. 😄

Use the gulp plugin rather than this module. That should fix it.