quahog icon indicating copy to clipboard operation
quahog copied to clipboard

Deprecation Error by default

Open splatEric opened this issue 3 years ago • 5 comments

I might be missing something horrendously obvious, but when I instantiate the client as laid out in the README, I get a deprecation notice, which in my environment is automatically an error.

Looking at the code, the mode parameter defaults to PHP_BINARY_READ and this mode immediately triggers the deprecation notice.

Would it be possible to release a version 4.x.x (to indicate a breaking change) that defaults to PHP_NORMAL_READ.

If not, perhaps it would be worth highlighting in the README? Happy to do a PR for either option ...

splatEric avatar Dec 22 '21 18:12 splatEric

We're getting this in our production logs as well. It's cluttering up our logs. Would love to have an option to switch the mode or have the library updated.

dswindle avatar Sep 08 '22 22:09 dswindle

Hi, the suggestion for the readme sounds like a nice transitional solution for now because I'm not familiar with the plans for Quahog 4.

SenseException avatar Sep 09 '22 20:09 SenseException

Any workaround?

dextervip avatar Oct 25 '22 14:10 dextervip

Is the bug still there

cth18012017 avatar Jan 18 '23 22:01 cth18012017

I had the same deprecation notice, I fixed it in this way:

<?php

$client = new Client($mySocket, mode: PHP_NORMAL_READ);


garak avatar Feb 12 '24 09:02 garak