quahog
quahog copied to clipboard
Deprecation Error by default
I might be missing something horrendously obvious, but when I instantiate the client as laid out in the README, I get a deprecation notice, which in my environment is automatically an error.
Looking at the code, the mode
parameter defaults to PHP_BINARY_READ
and this mode immediately triggers the deprecation notice.
Would it be possible to release a version 4.x.x (to indicate a breaking change) that defaults to PHP_NORMAL_READ
.
If not, perhaps it would be worth highlighting in the README? Happy to do a PR for either option ...
We're getting this in our production logs as well. It's cluttering up our logs. Would love to have an option to switch the mode or have the library updated.
Hi, the suggestion for the readme sounds like a nice transitional solution for now because I'm not familiar with the plans for Quahog 4.
Any workaround?
Is the bug still there
I had the same deprecation notice, I fixed it in this way:
<?php
$client = new Client($mySocket, mode: PHP_NORMAL_READ);