fritter icon indicating copy to clipboard operation
fritter copied to clipboard

[REQ] Optimize thread & reply depiction

Open RequestPrivacy opened this issue 3 years ago • 8 comments

Describe the problem that needs solving See explanation image

Describe the solution you'd like See explanation image

Thread

RequestPrivacy avatar Jun 24 '21 18:06 RequestPrivacy

This is a limitation that I'm not sure how to address unfortunately. For the API being used by groups/feeds, Twitter sends back no information on conversations or threads, and only sends back tweets from users that are requested in the query (i.e. your subscriptions). If a thread contains tweets from an account you're not subscribed to, or that account isn't in the current group, those tweets aren't returned.

However, Fritter does try its best with the tweets it is sent back - it will try to build a thread, even if it's only a partial one, but I'm not too sure how to load in any missing tweets (or even to know what those missing tweets are, without making O(n) API calls).

If anyone's more familiar with the Twitter APIs (public and private) than I am, let me know any ideas you might have!

jonjomckay avatar Jul 16 '21 16:07 jonjomckay

I don't have a good solution here other than recursive calls (with a max limit), but I know that Nitter handles this correctly. Is it possible to see what they do in this instance?

wattelengineering avatar Oct 12 '21 01:10 wattelengineering

@akengconsulting could you give a link to a tweet that Nitter handles correctly, but Fritter doesn't? Fritter uses the same methods as Nitter, so the data should be the same. It could just be that I'm displaying it wrong!

jonjomckay avatar Oct 19 '21 19:10 jonjomckay

@akengconsulting could you give a link to a tweet that Nitter handles correctly, but Fritter doesn't? Fritter uses the same methods as Nitter, so the data should be the same. It could just be that I'm displaying it wrong!

@jonjomckay For example see this tweet (it's part of a thread): https://twitter.com/BBC/status/1449832144226983946 Nitter shows the whole thread while emphasising the tweet in question: https://nitter.net/BBC/status/1449832144226983946#m

Open the same link in Fritter and it shows only the tweet with replies but without the previous tweets in the thread - only displaying a message that reads "Replying to @ BBC" which you have to press n times to see each prior tweet until you reach the beginning. The middle picture in the OP shows this.

Even if you have to make n calls here, I think that's better than the user having to press "Replying to..." n times.

wattelengineering avatar Oct 20 '21 02:10 wattelengineering

@akengconsulting thanks. This is actually fixed in the latest release! The last thing remaining is #254, which hides some vaguely related tweets behind the "load more" button

jonjomckay avatar Oct 20 '21 08:10 jonjomckay

I can confirm this is fixed for me in 2.15.1.

wattelengineering avatar Oct 24 '21 12:10 wattelengineering

Sorry I accidentally re-opened the issue.

wattelengineering avatar Oct 24 '21 12:10 wattelengineering

@jonjomckay Maybe I spoke too soon. Displaying threads works much better now but it looks like there's a max limit of 10 previous tweets. While having a limit is good, if the thread is longer than that, you get to the "top" and then you're back to pressing "Replying to..." n times again until you reach the real top. I don't know if this is the same issue or not but so I'll leave it here for now.

I suggest either having some kind of autoscrolling (when you get close to the "top" Fritter automatically fetches more previous tweets until there aren't any), or when the user hits "Replying to..." it scrolls by more than one at a time (e.g. 10). Also, if the second option is taken, maybe leave the tweet that was the previous top of the thread as a marker so it's clear what just happened.

wattelengineering avatar Oct 25 '21 05:10 wattelengineering

Closing as the feed has now been removed, due to Twitter blocking access permanently. Please see https://github.com/jonjomckay/fritter/issues/668#issuecomment-1528784190

jonjomckay avatar Apr 29 '23 14:04 jonjomckay