Jon Johnson

Results 232 comments of Jon Johnson

Following the breadcrumbs, I think this is resolved by https://github.com/knative/build-templates/pull/87 @dlorenc is that right?

This is probably my fault because I haven't finished adding proper manifest list support to [`ko`](https://github.com/google/go-containerregistry/blob/master/cmd/ko/README.md). The container images are built using `ko`, which defaults to using [`gcr.io/distroless/base:latest`](https://gcr.io/distroless/base:latest) [here](https://github.com/google/go-containerregistry/blob/b00487883a6e709b12a2a6d2bbb30525f7b86604/cmd/ko/config.go#L61). You...

For some context, that file is a symlink that points to the current git commit so that it can be used in logs (I think?). For example: https://github.com/knative/build/blob/master/cmd/controller/kodata/HEAD Was added...

Just to clarify -- is the target cluster you're trying to deploy to also PowerPC? Looks like we're failing to pull this: https://github.com/knative/serving/blob/114ee46c575df605fd38a94f2fe1c32107f30b2d/third_party/config/monitoring/metrics/prometheus/kubernetes/kube-state-metrics.yaml#L154-L155 Indeed it is amd64: `$`[`crane`](https://github.com/google/go-containerregistry/blob/master/cmd/crane/doc/crane.md)`config k8s.gcr.io/addon-resizer:1.7 |`[`jq`](https://stedolan.github.io/jq/)`.architecture`...

cc @tcnghia might have a better answer I believe that's because the knative serving controller needs cluster-admin permissions to create resource in other namespaces? It looks like you're missing [this](https://github.com/knative/serving/blob/master/config/201-clusterrolebinding.yaml)....

That could be an issue with how we're resolving tags to digests... If you add "gcr.io" to the configmap here: https://github.com/knative/serving/blob/06fae8be6da29137fd55b44557572566ef69f975/config/config-controller.yaml#L30 Does that fix things?

Is your network configured to allow pulling from `gcr.io/knative-samples/helloworld-go` to work?

This is on my plate but I haven't found time to get to it yet. If anyone is interested in helping, I made an issue here: https://github.com/google/go-containerregistry/issues/333 I want this...

I'm slowly working on this as part of some other work. We need to add support for pulling and pushing manifest lists to go-containerregistry for a variety of reasons, and...

@junawaneshivani I'd like to refactor that implementation to what I described in the PR. I filed an issue upstream to make that easier: https://github.com/google/go-containerregistry/issues/474 -- I'll need to fix that...