vast-vmap icon indicating copy to clipboard operation
vast-vmap copied to clipboard

VASTAds Constructor fix for new Chrome

Open Fire-Brand opened this issue 9 years ago • 3 comments

As discussed in issue #19 this fixes the getElementsByTagNameNS call with root.namespaceURI to call it with "*" .

Fire-Brand avatar Oct 19 '15 15:10 Fire-Brand

Could you please split this into two PRs -- one for each feature? I'm happy to merge both.

jonhoo avatar Oct 19 '15 16:10 jonhoo

I remember only sending one PR, the second one was just a commit, don't know why it popped up in this PR.

I'm not sure how to resend as 2 separate PRs, advice?

Fire-Brand avatar Oct 20 '15 08:10 Fire-Brand

It's because you made this change after already having committed your AdParameter fix. PRs include all commits that differ from master. Assuming origin points to your fork, and upstream points to this repo (see git remote -v), to create separate PRs, try:

git checkout -b pr1 upstream/master
git cherry-pick 3142292e65642b9c469e13b460ce7d6c950d319d
git push -u origin pr1
git branch -D pr1
git checkout -b p2 upstream/master
git cherry-pick 933d3fa0d49302114159c88d0c410cee8773894c
git push -u origin pr2
git branch -D pr2

You should now have two new branches in your fork: pr1 and pr2. Create a PR for each one, and they should only include the appropriate commit.

jonhoo avatar Oct 20 '15 13:10 jonhoo