rust-imap icon indicating copy to clipboard operation
rust-imap copied to clipboard

Replace mpsc::{Sender,Receiver} by VecDeque

Open soywod opened this issue 2 years ago • 3 comments

Fixes #254.


This change is Reviewable

soywod avatar May 11 '23 20:05 soywod

Codecov Report

Attention: Patch coverage is 93.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.5%. Comparing base (a7d22f0) to head (2beff59). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parse.rs 93.9% 5 Missing :warning:
src/client.rs 87.8% 4 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
src/extensions/list_status.rs 87.8% <100.0%> (ø)
src/extensions/metadata.rs 92.6% <100.0%> (ø)
src/types/acls.rs 98.4% <100.0%> (ø)
src/types/capabilities.rs 55.8% <100.0%> (ø)
src/types/fetch.rs 65.6% <100.0%> (ø)
src/types/name.rs 70.1% <100.0%> (ø)
src/types/quota.rs 93.7% <100.0%> (ø)
src/client.rs 92.7% <87.8%> (-0.1%) :arrow_down:
src/parse.rs 89.9% <93.9%> (+0.4%) :arrow_up:

codecov[bot] avatar May 11 '23 20:05 codecov[bot]

Hi @soywod I really like this PR and it also looks super close to being finished. Is there anyway I can help get this merged?

bogthe avatar Apr 09 '24 09:04 bogthe

I forgot about this PR as it did not fix my initial issue. I can take a look back during this week and see if I can complete it.

soywod avatar Apr 10 '24 15:04 soywod

Sorry for the very long delay. The PR is ready for another review!

soywod avatar Jan 01 '25 10:01 soywod