rust-imap icon indicating copy to clipboard operation
rust-imap copied to clipboard

Implementing capability caching

Open dequbed opened this issue 2 years ago • 3 comments

Based on this comment by @jonhoo on #243 this PR adds the ability for Client and Session to cache returned Capabilities.

Future work should try to parse (the optionally sent) Capabilities from untagged responses to EHLO, STARTTLS, and AUTHENTICATE automatically; if none are sent they should be automatically queried.


This change is Reviewable

dequbed avatar Feb 06 '23 13:02 dequbed

Codecov Report

Merging #255 (04f5c9e) into main (41c5597) will decrease coverage by 0.8%. The diff coverage is 33.8%.

Additional details and impacted files
Impacted Files Coverage Δ
src/client.rs 91.5% <26.0%> (-1.7%) :arrow_down:
src/types/capabilities.rs 55.9% <56.2%> (+0.1%) :arrow_up:

codecov[bot] avatar Feb 11 '23 19:02 codecov[bot]

I think the last bit here now is https://github.com/jonhoo/rust-imap/pull/255#discussion_r1125573266

jonhoo avatar Mar 11 '23 18:03 jonhoo

Hi @dequbed, I really liked that you were adding support for SASL in #243. Do you have any plans to update this PR? If you're short on time, I would be happy to help getting this (and that one) merged!

bogthe avatar Apr 07 '24 15:04 bogthe