inferno icon indicating copy to clipboard operation
inferno copied to clipboard

Bump MSRV to match clap dependency

Open rukai opened this issue 10 months ago • 2 comments

Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70 This PR:

  • bumps inferno's MSRV to 1.70
  • makes use of a new stdlib API in 1.70 to drop the is-terminal and rustix dependencies.
    • This was also cargo's motivation for bumping MSRV which is how I noticed we could do the same here.

rukai avatar Aug 25 '23 01:08 rukai

Codecov Report

Patch and project coverage have no change.

Comparison is base (5d88bc3) 91.01% compared to head (8af0614) 91.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          19       19           
  Lines        4385     4385           
=======================================
  Hits         3991     3991           
  Misses        394      394           
Files Changed Coverage Δ
src/collapse/mod.rs 96.96% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '23 19:08 codecov[bot]

Understandable, I'll mark this as draft so it's around when it's needed.

rukai avatar Aug 25 '23 21:08 rukai