inferno icon indicating copy to clipboard operation
inferno copied to clipboard

Add support for collapsing PHP Xdebug traces

Open MaartenStaa opened this issue 2 years ago • 1 comments

Inspired by and continued from #126 by @daniellockyer

This PR is a bit different, because in the meantime Xdebug 3 was released, which apparently introduced a new tracing format as far as I can tell based on the samples I've taken, and the old code. One caveat is that Xdebug actually produces gzipped files, which is not (yet) handled here, as it seems a bit out of scope for this tool.

I went through the comments on the old PR and think I've tackled them all, but please let me know if you have any other feedback.

Also, I love your streams and your book, keep up the great work :)

MaartenStaa avatar Jun 21 '22 15:06 MaartenStaa

Codecov Report

Merging #253 (0dccda7) into master (acc8981) will decrease coverage by 0.50%. The diff coverage is 79.37%.

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   87.32%   86.82%   -0.51%     
==========================================
  Files          18       19       +1     
  Lines        2525     2687     +162     
==========================================
+ Hits         2205     2333     +128     
- Misses        320      354      +34     
Impacted Files Coverage Δ
src/collapse/mod.rs 52.63% <ø> (ø)
src/collapse/xdebug.rs 78.98% <78.98%> (ø)
src/collapse/guess.rs 72.09% <100.00%> (+1.36%) :arrow_up:
src/flamegraph/svg.rs 75.90% <0.00%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acc8981...0dccda7. Read the comment docs.

codecov[bot] avatar Jun 22 '22 03:06 codecov[bot]