griddle icon indicating copy to clipboard operation
griddle copied to clipboard

Consider upgrading hashbrown to 0.11.2?

Open PsiACE opened this issue 3 years ago • 1 comments

It seems that hashbrown 0.11.2 has quite a big change compared to 0.9.1. Will griddle consider following up?

PsiACE avatar Apr 26 '21 09:04 PsiACE

I think it would be worthwhile to update griddle to hashbrown 0.11, but unfortunately have limited time to do so myself since I'm not actively using griddle any longer. I'd be happy to help review a PR though!

In general the process should be straightforward — just diff each file in griddle against the corresponding file in hashbrown, and reconcile the differences (looking primarily at pub fns and pub types). For most diffs, it should be clear what has to happen. I would probably generally advise against introducing new methods unless their implementation is obvious — we can always add those later on in separate PRs.

There are a few changes I'd avoid for griddle in a version update PR:

  • The move to A: Allocator. That is something we should adopt eventually, but I'd keep that separate.
  • Anything related to DrainFilter.
  • Anything behind #[cfg(feature = "nightly")].

The raw module is the one that seems the most onerous because the implementation doesn't match up as nicely, but in most cases the griddle implementation just forwards to the hashbrown implementation with some extra bits here and there.

jonhoo avatar Apr 27 '21 00:04 jonhoo