faktory-rs icon indicating copy to clipboard operation
faktory-rs copied to clipboard

Support remove queues, as well as pause all / resume all

Open rustworthy opened this issue 10 months ago • 2 comments

Addresses #56 and #60


This change is Reviewable

rustworthy avatar Apr 09 '24 17:04 rustworthy

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.7%. Comparing base (eac9545) to head (3b33790).

Additional details and impacted files
Files Coverage Δ
src/proto/single/cmd.rs 97.5% <100.0%> (+2.5%) :arrow_up:
src/proto/client/mod.rs 84.3% <73.3%> (+0.8%) :arrow_up:

codecov[bot] avatar Apr 09 '24 19:04 codecov[bot]

going to hold off on reviewing this until after #49

jonhoo avatar Apr 27 '24 16:04 jonhoo

@jonhoo

I encountered some issues when trying to make Client hold a boxed dyn Connection . Our Reconnect trait mentions Self in the return value of it's only method, making the whole thing not object safe. So introducing a Client which is a struct with the following shape ...

type Connection = Box<FaktoryConnection>;
struct Client {
  connection: Connection,
  opts: ClientOptions,
 }

... did not work.

I might be missing something though..

Otherwise the PR is ready for review.

rustworthy avatar May 14 '24 06:05 rustworthy

Would you mind splitting this PR into multiple, one for each logical change? It's a little hard to review the changes when multiple of them are bundled together in this way.

jonhoo avatar May 19 '24 14:05 jonhoo

Would you mind splitting this PR into multiple, one for each logical change? It's a little hard to review the changes when multiple of them are bundled together in this way.

Sure

rustworthy avatar May 19 '24 18:05 rustworthy

@jonhoo

Only queue control actions are left in this PR. Please have a look at it once again

rustworthy avatar May 20 '24 08:05 rustworthy