Jon Gjengset

Results 867 comments of Jon Gjengset

WIP thoughts: I'm working on reviewing the repository. I have not reviewed everything yet. I will track my thoughts as they come here. Actionable takeaways should be tracked in dedicated...

From some discussion: probably fine to replace the `VecDequeue` for requests with a single "slot" to buffer a failed `start_send`, and then do the send of that in `poll_ready`.

First implementation here: https://github.com/jonhoo/ordsearch

Some observations: it seems like the implemented algorithm is only faster when `n` is small and when the data type is relatively large. A straightforward binary search is faster once...

@patmorin after doing some more experiments, my code is actually faster if I comment out the pre-fetching, which suggests that it's prefetching the wrong value. However, as far as I...

Sorry for the spam, but I walked through the calculation carefully, and I think I get it now. Left a somewhat long-winded comment here: https://github.com/jonhoo/ordsearch/blob/b17cb0b3f5089112145af25dfad6bbc8376c408a/src/lib.rs#L292 However, given that this all...

Thank you for taking the time to write up a PR! I'd actually prefer to do this without bringing in `num` as a dependency. It's mostly unnecessary, and also still...