bustle icon indicating copy to clipboard operation
bustle copied to clipboard

Make time measurement panic safe

Open wvwwvwwv opened this issue 1 year ago • 1 comments

Hi again,

This PR puts the std::sync::Barrier in a workload thread into a scopeguard to ensure that the barrier is correctly waited under almost any circumstances, therefore panics in the thread won't result in the entire benchmark run hanging.

Note that this does not cover a situation where spawning a thread fails due to an OoM or the like.

wvwwvwwv avatar Sep 05 '22 00:09 wvwwvwwv

Codecov Report

Base: 1.43% // Head: 1.42% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (f329222) compared to base (13d1ed7). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #11      +/-   ##
=========================================
- Coverage    1.43%   1.42%   -0.02%     
=========================================
  Files           3       3              
  Lines         209     211       +2     
=========================================
  Hits            3       3              
- Misses        206     208       +2     
Impacted Files Coverage Δ
src/lib.rs 1.69% <0.00%> (-0.02%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 05 '22 00:09 codecov-commenter

Released as 0.4.4 :tada:

jonhoo avatar Sep 17 '22 19:09 jonhoo