onsets-and-frames
onsets-and-frames copied to clipboard
Suggest to loosen the dependency on sacred
Dear developers,
Your project onsets-and-frames requires "sacred==0.7.4" in its dependency. After analyzing the source code, we found that the following versions of sacred can also be suitable without affecting your project, i.e., sacred 0.7.3. Therefore, we suggest to loosen the dependency on sacred from "sacred==0.7.4" to "sacred>=0.7.3,<=0.7.4" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.
May I pull a request to further loosen the dependency on sacred?
By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?
Details:
Your project (commit id: 783ca08498bb8ada41516c9ed492868b4e947abf) directly uses 3 APIs from package sacred.
sacred.experiment.Experiment.__init__, sacred.observers.file_storage.FileStorageObserver.create, sacred.commands.print_config
Beginning fromwhich, 44 functions are then indirectly called, including 25 sacred's internal APIs and 19 outsider APIs as follows:
[/jongwook/onsets-and-frames]
+--sacred.experiment.Experiment.__init__
| +--inspect.stack
| +--os.path.basename
| +--sacred.ingredient.Ingredient.__init__
| | +--collections.OrderedDict
| | +--inspect.stack
| | +--os.path.dirname
| | +--os.path.abspath
| | +--sacred.dependencies.gather_sources_and_dependencies
| | | +--sacred.dependencies.get_main_file
| | | | +--os.path.abspath
| | | | +--sacred.dependencies.Source.create
| | | | | +--os.path.exists
| | | | | +--sacred.dependencies.get_py_file_if_possible
| | | | | | +--os.path.exists
| | | | | +--os.path.abspath
| | | | | +--sacred.dependencies.get_commit_if_possible
| | | | | | +--os.path.dirname
| | | | | | +--git.Repo
| | | | | | +--git.Repo.is_dirty
| | | | | | +--git.Repo.remote
| | | | | +--sacred.dependencies.Source.__init__
| | | | | +--sacred.dependencies.get_digest
| | | | | | +--hashlib.md5
| | | | +--os.path.dirname
| | | +--sacred.dependencies.PackageDependency.create
| | | | +--sacred.dependencies.PackageDependency.__init__
| +--sacred.ingredient.Ingredient.command
| | +--sacred.ingredient.Ingredient.capture
| | | +--sacred.config.captured_function.create_captured_function
| | | | +--sacred.config.signature.Signature.__init__
| | | | | +--sacred.config.signature.get_argspec
| | | | | | +--inspect.signature
| | | | | | +--collections.OrderedDict
| | | | | | +--inspect.getfullargspec
| | | | | | +--inspect.getargspec
| | | | +--sacred.config.captured_function.captured_function
| | | | | +--sacred.config.custom_containers.FallbackDict.__init__
| | | | | +--sacred.randomness.get_seed
| | | | | | +--random.randint
| | | | | +--sacred.randomness.create_rnd
| | | | | | +--random.Random
| | | | | +--time.time
| | | | | +--datetime.timedelta
+--sacred.observers.file_storage.FileStorageObserver.create
| +--os.path.exists
| +--os.makedirs
| +--os.path.join
| +--sacred.utils.FileNotFoundError.__init__
+--sacred.commands.print_config
| +--sacred.commands._format_config
| | +--sacred.commands._iterate_marked
| | | +--sacred.utils.iterate_flattened_separately
| | | | +--sacred.utils.iterate_flattened_separately
| | | | | +--sacred.utils.join_paths
| | +--sacred.commands._format_entry
Since all these functions have not been changed between any version for package "sacred" from [0.7.3] and 0.7.4. Therefore, we believe it is safe to loosen the corresponding dependency.