memealyzer icon indicating copy to clipboard operation
memealyzer copied to clipboard

abstracted the image provider

Open bradygaster opened this issue 5 years ago • 5 comments

this prepares the app for non-reddit-based meme providers. like, maybe I want to set one up that searches for a specific term using the bing image search api and returns memes based on my search criteria?

this enables that sort of thing.

bradygaster avatar Dec 11 '20 04:12 bradygaster

@jongio will address your feedback thus far once you see the additional stuff i've added. would need some support from you on getting the provisioning part dialed in. Also, I don't like the way i'm persisting the "search term" string, so look at that and see if you have any feedback. This was fun!

bradygaster avatar Dec 11 '20 08:12 bradygaster

new updates add app config enabled setting of the image provider also enables setting of the search term and the key

bradygaster avatar Dec 11 '20 20:12 bradygaster

This is a great add. I would like to get it in there. To do so, we'd have to rebase and update with new structure. LMK if that is something you are interested in doing. Just a heads up that a lot has changed since this update, so it might be a bit of work to get it done.

jongio avatar Jul 29 '21 14:07 jongio

Yeah i'd need to start anew for sure. :) You think this one has merit?

bradygaster avatar Aug 09 '21 17:08 bradygaster

It depends on your interest level and time. It's not something that I need per se as it isn't making use of a new lib. But happy to support you if you want to add it.

jongio avatar Aug 09 '21 20:08 jongio