hnn
hnn copied to clipboard
jonescompneurolab
update dockerfile - maint/pre-hnn-core branch
@jashlu thanks for your work on this. Is it ready for a final review, or is there still more to do?
@jashlu thanks for your work on this. Is it ready for a final review, or is there still more to do?
Hi thanks for the reminder, I wasn't sure which one of the two PRs would be merged in, are we updating both the main and maint/pre-hnn-core branches? @rythorpe
I think the final decision was to just stick with the docker build for maint/pre-hnn-core as the official version we recommend.
@dylansdaniels perhaps let's discuss in our next meeting updating the website documentation to make this clearer? right now people will be attempting to install a version of HNN-GUI that is fairly unstable as hnn-core continues to change
Just to clarify @jashlu, we went ahead and merged your recent docker build changes for master since you already had it working, but still want to encourage users to use the docker build on maint/pre-hnn-core.
Just to clarify @jashlu, we went ahead and merged your recent docker build changes for
mastersince you already had it working, but still want to encourage users to use the docker build onmaint/pre-hnn-core.
Understood, thanks for the explanation. I will hold off on merging just for a bit while I work through adding the script to simplify one step in the xserver installation, I will tag you guys for re-review when it is done, should be done soon, thanks!
I'll try to test this out on my windows machine this weekend. Feel free to bug me early next week if I don't get back to you soon @jashlu!
I'll try to test this out on my windows machine this weekend. Feel free to bug me early next week if I don't get back to you soon @jashlu!
That would be greatly appreciated, have a great weekend!
@dylansdaniels I just noticed your comment in #337. Are you fetching from this branch? If not, I believe this the branch we (maint/pre-hnn-core) that we want to be testing and using in the future.
So I was moreso referring to how if you follow the docker instructions in the pre-hnn-core branch, it will have you clone from hnn.git, which will put you on master branch. And then if you proceed to the next step in the instructions, it'll direct you to ./scripts/configure_vcxsrv.sh, but you won't be on the branch that has that file.
Sorry for the delay @rythorpe. That covers it in terms things I bumped into doing a fresh install on Windows 11
I just realized we never completed this. Since I'm pretty sure it's ready to go, let's go ahead and merge. Thanks @jashlu!