hnn-core
hnn-core copied to clipboard
REF: Refactor bias handling
Re-organize External Bias handling to resemble how External Drives are handled:
- [ ] Distinguish between
typeandnamefor biases (similar to drives)- (This should allow for better organization of multiple biases of the same type but different names in params usage)
- [ ] Separate bias code from drive code (such as in
drives.py:_add_drives_from_params()) - [ ] Update config file format to reflect these changes, including both separation of type and name
- Note that for this reason, this should probably be done after #962 is complete.
- [ ] Un-hardcode any current code that only uses
tonic(such asparams.py::_extract_bias_specs_from_hnn_params()) - What else?
Don't think any "refactor" issue is a "good first issue" ;-) Do keep in mind that if you change the internals in a way that it may break user code, you would have to deprecate ... if it's just moving private functions around, then there is no need to worry of course.
particularly if you want the code to be adopted outside Jones lab; it is sometimes better to keep sub-optimal code if it doesn't break old user code.
Good point on not making this a good first issue, especially since it may be a breaking change. I need a deeper understanding of our config/network/data format first before I begin making any possible breaking changes to it.