hnn-core icon indicating copy to clipboard operation
hnn-core copied to clipboard

REF: Refactor bias handling

Open asoplata opened this issue 10 months ago • 2 comments

Re-organize External Bias handling to resemble how External Drives are handled:

  • [ ] Distinguish between type and name for biases (similar to drives)
    • (This should allow for better organization of multiple biases of the same type but different names in params usage)
  • [ ] Separate bias code from drive code (such as in drives.py:_add_drives_from_params())
  • [ ] Update config file format to reflect these changes, including both separation of type and name
    • Note that for this reason, this should probably be done after #962 is complete.
  • [ ] Un-hardcode any current code that only uses tonic (such as params.py::_extract_bias_specs_from_hnn_params())
  • What else?

asoplata avatar Jan 10 '25 17:01 asoplata

Don't think any "refactor" issue is a "good first issue" ;-) Do keep in mind that if you change the internals in a way that it may break user code, you would have to deprecate ... if it's just moving private functions around, then there is no need to worry of course.

particularly if you want the code to be adopted outside Jones lab; it is sometimes better to keep sub-optimal code if it doesn't break old user code.

jasmainak avatar Jan 10 '25 21:01 jasmainak

Good point on not making this a good first issue, especially since it may be a breaking change. I need a deeper understanding of our config/network/data format first before I begin making any possible breaking changes to it.

asoplata avatar Jan 13 '25 14:01 asoplata