hnn-core
hnn-core copied to clipboard
GUI: Clean up dev debug checks
Reminder for CCV to review GUI script and remove any development code used for debugging or TODO references when GUI is ready for release.
To Do
- [ ] Remove try/except clauses used for development
- [ ] Remove TODO comments
I noticed that some loggers have been added to the GUI for debugging purposes:
https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/gui/_logging.py
I'd recommend a different solution. You should use the output widgets the ipywidgets comes with:
https://ipywidgets.readthedocs.io/en/latest/examples/Output%20Widget.html
we have a variable called log_out
for that purpose. Unfortunately it's not implemented consistently, so I'd recommend fixing it rather than introduce a new half-baked solution.
We need a repo-wide logger too -- but that's a separate problem. For now, if all the gui code was wrapped into the existing log_out
that would be super.
Ideally we'd have a repo-wide logger with verbose
parameter. And this would be integrated with the jupyter logger using code like this:
https://ipywidgets.readthedocs.io/en/latest/examples/Output%20Widget.html#integrating-output-widgets-with-the-logging-module
cc @ntolley ... ties in with our discussion of verbose
parameter for batch processing