hnn-core icon indicating copy to clipboard operation
hnn-core copied to clipboard

[WIP] GUI tutorial gamma

Open jasmainak opened this issue 3 years ago • 7 comments

I am volunteering for the gamma tutorial. The diff will look better once #529 is merged

@chenghuzi I need a method to show a particular drive. Do we have that?

jasmainak avatar Aug 08 '22 01:08 jasmainak

Codecov Report

Merging #535 (558c220) into master (52ee292) will decrease coverage by 0.12%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   90.24%   90.12%   -0.13%     
==========================================
  Files          20       20              
  Lines        3988     3968      -20     
==========================================
- Hits         3599     3576      -23     
- Misses        389      392       +3     
Impacted Files Coverage Δ
hnn_core/parallel_backends.py 81.49% <0.00%> (-0.83%) :arrow_down:
hnn_core/cell_response.py 84.00% <0.00%> (-0.54%) :arrow_down:
hnn_core/extracellular.py 86.69% <0.00%> (-0.26%) :arrow_down:
hnn_core/cell.py 97.10% <0.00%> (-0.11%) :arrow_down:
hnn_core/gui/gui.py 84.97% <0.00%> (-0.03%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 12 '22 03:08 codecov-commenter

@chenghuzi I need a method to show a particular drive. Do we have that?

@chenghuzi do we have this feature implemented in #543 ? Do you anticipate any other blockers for this tutorial to be finished?

jasmainak avatar Aug 29 '22 21:08 jasmainak

@chenghuzi I need a method to show a particular drive. Do we have that?

@chenghuzi do we have this feature implemented in #543 ? Do you anticipate any other blockers for this tutorial to be finished?

That's hard. We can turn on the selected_index but since the drive tab is usually very long so setting index to the one we want to see won't help. To do that you need to scroll, but that requires manipulation with javascript.

chenghuzi avatar Aug 29 '22 21:08 chenghuzi

Once we turn legacy_mode False by default we won’t have more than 3 drives in a tutorial. Still need to scroll?

On Mon 29 Aug 2022 at 17:45, Huzi Cheng @.***> wrote:

@chenghuzi https://github.com/chenghuzi I need a method to show a particular drive. Do we have that?

@chenghuzi https://github.com/chenghuzi do we have this feature implemented in #543 https://github.com/jonescompneurolab/hnn-core/pull/543 ? Do you anticipate any other blockers for this tutorial to be finished?

That's hard. We can turn on the selected_index but since the drive tab is usually very long so setting index to the one we want to see won't help. To do that you need to scroll, but that requires manipulation with javascript.

— Reply to this email directly, view it on GitHub https://github.com/jonescompneurolab/hnn-core/pull/535#issuecomment-1230895142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY6FIUWSYGG3GBV2QN5SBDV3UVOLANCNFSM553NJW5A . You are receiving this because you authored the thread.Message ID: @.***>

-- Sent from my iPhone

jasmainak avatar Aug 29 '22 21:08 jasmainak

Once we turn legacy_mode False by default we won’t have more than 3 drives in a tutorial. Still need to scroll? On Mon 29 Aug 2022 at 17:45, Huzi Cheng @.> wrote: @chenghuzi https://github.com/chenghuzi I need a method to show a particular drive. Do we have that? @chenghuzi https://github.com/chenghuzi do we have this feature implemented in #543 <#543> ? Do you anticipate any other blockers for this tutorial to be finished? That's hard. We can turn on the selected_index but since the drive tab is usually very long so setting index to the one we want to see won't help. To do that you need to scroll, but that requires manipulation with javascript. — Reply to this email directly, view it on GitHub <#535 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY6FIUWSYGG3GBV2QN5SBDV3UVOLANCNFSM553NJW5A . You are receiving this because you authored the thread.Message ID: @.> -- Sent from my iPhone

This is the expaned first drive: image We can only see about half of its height. So I don't think it will be that helpful. Besides, since we take the "screenshot" with Iframe, so the user can click the tab themselves

chenghuzi avatar Aug 29 '22 21:08 chenghuzi

This is fine for me. Other alternative is to show only the widget of concern ... that is also pretty easy I believe through because the ipywidgets object stores the entire widget tree. Probably need a function to display that widget. Not sure which is better from the perspective of a user reading the tutorial ...

jasmainak avatar Aug 30 '22 10:08 jasmainak

@chenghuzi feel free to take this over !

jasmainak avatar Dec 12 '22 18:12 jasmainak