hnn-core icon indicating copy to clipboard operation
hnn-core copied to clipboard

[MRG] Add ability to record voltages and currents from all sections

Open ntolley opened this issue 2 years ago • 2 comments

This is an enhancement I've been meaning to add for awhile. Not sure if this is going to cause a lot of problems in terms of data transfer, but we'll see!

The way things are currently written are very redundant with the somatic recording functionality. Once I know this is working, the record_vsoma and record_isoma options to simulate_dipole can use the same code as here by restricting the section names considered to only be the 'soma'.

ntolley avatar Jul 15 '22 17:07 ntolley

Codecov Report

Merging #502 (af2a8f0) into master (1f22230) will decrease coverage by 0.04%. The diff coverage is 98.30%.

:exclamation: Current head af2a8f0 differs from pull request most recent head 280878e. Consider uploading reports for the commit 280878e to get more accurate results

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   91.81%   91.77%   -0.05%     
==========================================
  Files          22       22              
  Lines        4214     4229      +15     
==========================================
+ Hits         3869     3881      +12     
- Misses        345      348       +3     
Impacted Files Coverage Δ
hnn_core/params_default.py 100.00% <ø> (ø)
hnn_core/cell.py 96.85% <95.65%> (-0.26%) :arrow_down:
hnn_core/cell_response.py 84.00% <100.00%> (ø)
hnn_core/dipole.py 92.45% <100.00%> (-0.05%) :arrow_down:
hnn_core/network_builder.py 93.85% <100.00%> (+0.08%) :arrow_up:
hnn_core/parallel_backends.py 81.38% <100.00%> (-0.56%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Dec 08 '22 21:12 codecov-commenter

@rythorpe @jasmainak took a little sabbatical from this PR but everything seems to be working now! Might be a nice add-on to the 0.3 :wink:

ntolley avatar Dec 08 '22 21:12 ntolley

Cursorily looks fine barring the tiny comment. I trust you tested it properly :)

jasmainak avatar Dec 14 '22 22:12 jasmainak

good to go from your end @ntolley ?

jasmainak avatar Dec 16 '22 05:12 jasmainak

good to go from your end @ntolley ?

All good with me once the CI's are green! Just pushed the last commit addressing your comment

ntolley avatar Dec 16 '22 19:12 ntolley

Thanks @ntolley ! great stuff 🥳 🥳 🥳

jasmainak avatar Dec 16 '22 19:12 jasmainak