hnn-core icon indicating copy to clipboard operation
hnn-core copied to clipboard

remove redundant function drive_event_times

Open jasmainak opened this issue 3 years ago • 2 comments

It looks we have two copies of the same function:

drive_event_times _drive_cell_event_times

we should remove one of them and update the tests to use only one function

jasmainak avatar Feb 06 '22 00:02 jasmainak

This is addressed in #431. I'll need to update myself on the status of that PR but I think it can be pushed through rather quickly.

rythorpe avatar Feb 06 '22 18:02 rythorpe

indeed, sorry about missing that!

jasmainak avatar Feb 07 '22 21:02 jasmainak

Hey @jasmainak @rythorpe can I work on this?

raj1701 avatar Mar 06 '23 18:03 raj1701

Turns out this is actually already being addressed in #431. Sorry @raj1701!

rythorpe avatar Mar 06 '23 22:03 rythorpe

No problem at all @rythorpe. I will work on something else

raj1701 avatar Mar 07 '23 06:03 raj1701