[WIP] clean up network and drive tests

[rythorpe]

• [x] remove drive_event_times() from drives.py and update tests. Edit: note that drives.py will still have _drive_cell_event_times() which now entirely replaces the legacy drive_event_times() function.
• [ ] set add_drives_from_params=False and define drives explicitly whenever possible in test_network.py
• [ ] simplify _get_prng() in drives.py

closes #394

[codecov-commenter]

Codecov Report

Merging #431 (c35828b) into master (05a8f09) will increase coverage by 0.21%. The diff coverage is 96.55%.

:exclamation: Current head c35828b differs from pull request most recent head 4a733ca. Consider uploading reports for the commit 4a733ca to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   91.94%   92.15%   +0.21%     
==========================================
  Files          22       22              
  Lines        4257     4219      -38     
==========================================
- Hits         3914     3888      -26     
+ Misses        343      331      -12     

Impacted Files	Coverage Δ
hnn_core/__init__.py	100.00% <ø> (ø)
hnn_core/network.py	93.34% <ø> (ø)
hnn_core/gui/_viz_manager.py	89.00% <66.66%> (+0.39%)	:arrow_up:
hnn_core/dipole.py	92.45% <100.00%> (ø)
hnn_core/drives.py	98.54% <100.00%> (+6.05%)	:arrow_up:
hnn_core/gui/gui.py	96.44% <100.00%> (-0.02%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rythorpe]

Ready for your review @jasmainak @ntolley! I ended up refactoring the network tests so that they're more unit-like while hopefully retaining all of the original logic. Since this is all maintenance, we probably don't need to add anything to whats_new.rst right?

[rythorpe]

I think this is ready to go @jasmainak @ntolley @chenghuzi if any of you want to take a look.

[jasmainak]

we probably don't need to add anything to whats_new.rst right?

correct, I don't think you've changing anything that is user-facing.

[rythorpe]

Just rebased to get the linkcheck to pass. Ready to mrg pending @ntolley's review.

[rythorpe]

Looks like merging @ntolley's latest PR didn't create a merge conflict... ready to go whenever you are @jasmainak @ntolley!

[jasmainak]

Thanks a ton @rythorpe !! Great stuff :partying_face: