inconsistency in naming L5Pyr vs L5_pyramidal

[jasmainak]

There is inconsistency in naming of parameters within HNN. Sometimes the name L5_pyramidal and other times it's called L5Pyr. This makes it hard to refactor some parts of the code. I'm wondering if we should rename them all to use the L5Pyr convention. The params files won't be affected since they already conform to this convention.

Could be an easy (not sure ...) issue for a new contributor to get familiar with the codebase.

[Kartik-Khandelwal]

sir, i want to work on it. Kindly assign it to me.

All i need to do is to rename all "L5_pyramidal" to "L5Pyr" ? if yes, then assign to me. else, kindly explain a bit.

[ntolley]

Revitalizing this issue, @jasmainak can we plan to discuss this on a video call?

[jasmainak]

For sure let's do that!

[raj1701]

Hey @ntolley @jasmainak , Is this issue still open?

[raj1701]

L5pyr is just a short name for L5_pyramidal as given in params.py. There is a lot of usage for both the names. I am thinking to just rename L5_pyramidal to L5pyr in each file and continuously checking any code or tests are not breaking down. Am I in the right direction?

[jasmainak]

@raj1701 let's go one issue at a time. I'd like to see you have your first PR merged before moving on to new PRs

[raj1701]

Sure lets do this. I was just looking through the issues and thought I could contribute here.