bubblechart icon indicating copy to clipboard operation
bubblechart copied to clipboard

Main entry set for package #3

Open rafaelpivato opened this issue 10 years ago • 2 comments

Adds main entry point for bubblechart so it can be imported using requirejs or something similar.

Warning: My tests did not pass locally, apparently because of changes in QUnit or PhantomJS. As last TravisCI build happened 1 year ago, going through a new build could impose some new issues and require more fixes.

rafaelpivato avatar Dec 02 '15 15:12 rafaelpivato

As mentioned in #3, we probably want some work to be done to prevent it from attaching globally, if a module system (AMD/CommonJS) is in use. Returning only the BubbleChart class.

jondavidjohn avatar Dec 02 '15 16:12 jondavidjohn

:disappointed: probably should handle the methods in patches.coffee better, probably should not be extending the Canvas prototype :grimacing: and maybe there is a requestAnimationFrame polyfill available on npm?

Been awhile since I looked at this code :sweat_smile:

jondavidjohn avatar Dec 02 '15 16:12 jondavidjohn