Jonathan Barrow
Jonathan Barrow
Another key point for the contribution guide would be the quality of commit messages. We have a staggering number of outside contributors who make changes with commits like `updated file`,...
> When we say "approved issue", does this mean that the issue must be manually verified by a member? Yes. The issue templates I've set up automatically add a `awaiting-approval`...
> the document itself is also fairly long, might be worthwhile to trim it I took notes from various existing contribution guides and this one is about the same length...
> I'm really glad that you're starting to prioritize allowing external contributions. As someone who was, until recently, very much outside of Pretendo development, I generally got the vibe that...
> +1 to Matthew's idea of a free contributors channel I'm open to an idea like this, but I don't think it would be right to just make the dev...
I appreciate your input, as the one who inspired this idea :+1: thank you for this > You still get about 30% garbage PR's, it doesn't stop completely Definitely. I'm...
> I think you may be able to use github projects for it I want to drop all of our use of GitHub Projects entirely. We already use it for...
> Would `enhancement` be a good tag for an issue that you want to write a feature to later PR for? There's already a feature request issue template which would...
> Aware that I've not actually contributed anything as of yet but thought I'd add some thoughts 😅 All opinions are welcome, and your first hand experience trying to jump...
I've now added the `enhancement` issue template which can be used to request incremental changes to existing features. This should satisfy the issue jvs mentioned. I have also clarified our...