tweet-tray icon indicating copy to clipboard operation
tweet-tray copied to clipboard

Add support for localizations

Open jonathontoon opened this issue 7 years ago • 10 comments

Going to use react-localization. Even though Twitter accounts have a language setting which comes down from the API I think basing the locale off what the computer is using will be the way to go. Will avoid allowing a user to customize their language for now.

Below is a list of all the custom strings supported by Tweet Tray (which cannot already be sourced from Twitter's apps), and a list of which languages require localization.

If you would like to contribute, you can submit a pull request (following these (guidelines)[https://github.com/jonathontoon/tweet-tray#development]) for strings per language found under app/localizations. If the there is not a file for your language (e.g: en-US.json) you can create it as part of the pull request.

Language Status
Arabic (ar)
Bengali (bn)
Czech (cz)
Danish (da)
German (de) ✔️
Greek (el)
Spanish (es) ✔️
Persian (pr)
English (en) ✔️
Finnish (fi)
Filipino (fill)
French (fr) ✔️
Hebrew (he)
Hindi (hi)
Hungarian (hu)
Indonesian (id)
Italian (it)
Japanese (ja) ✔️
Korean (ko) ✔️
Malay (msa)
Dutch (nl)
Norwegian (no)
Polish (pl)
Portuguese (pt)
Romanian (ro)
Russian (ru)
Swedish (sv) ✔️
Thai (th)
Turkish (tr)
Ukrainian (uk)
Urdu (ur)
Vietnamese (vi)
Chinese (Simplified) (zh-CN) ✔️
Chinese (Traditional) (zh-TW) ✔️

jonathontoon avatar Feb 03 '18 04:02 jonathontoon

I'd be happy to work on German.

harleo avatar Feb 03 '18 13:02 harleo

Could you link the english localisation file so we can PR it?

neauoire avatar Feb 16 '18 03:02 neauoire

@neauoire yup, will add it to develop soon. I'd like to support all options for contribution especially for those who aren't comfortable in committing files/making a PR.

jonathontoon avatar Feb 16 '18 03:02 jonathontoon

Sounds good I'll try to do french & Lietal

neauoire avatar Feb 16 '18 04:02 neauoire

I can help with Arabic translation. Does the UI support RTL at the moment?

maroun-baydoun avatar Feb 16 '18 04:02 maroun-baydoun

@neauoire you can now find the strings under app/localizations in develop. I'm unsure how support for Lietal will work, as everything is based off electron's getLocale() method right now which supports these languages.

@maroun-baydoun I haven't tested RTL yet, but getting all of the strings for such languages is the starting place. I'm honestly expecting some of the UI to break for other languages too, but therein lies the challenge to fix things. 😆

Once strings are in I will make sure they wont ship without RTL support. Unless you'd like to give it a go.

@harleo ready for your help!

jonathontoon avatar Feb 16 '18 05:02 jonathontoon

@jonathontoon Done. #115

harleo avatar Feb 16 '18 05:02 harleo

@maroun-baydoun any interest still in doing Arabic?

jonathontoon avatar Mar 09 '18 05:03 jonathontoon

@jonathontoon Yes, I will do it and send a PR.

maroun-baydoun avatar Mar 12 '18 01:03 maroun-baydoun

Ja related issue: https://github.com/jonathontoon/tweet-tray/issues/194

riomarmccartney avatar Feb 11 '19 06:02 riomarmccartney