inclusive-code-reviews-browser icon indicating copy to clipboard operation
inclusive-code-reviews-browser copied to clipboard

Explore handling of words in various forms

Open rachelkang opened this issue 4 years ago • 2 comments

What will we do when a word...

  • is plural? - It might add an -s, -es, and/or change letters (i.e. wolf --> wolves, woman --> women).
  • is in a different tense? -ed, -ing, - i.e. currently, the tool will flag "master", but not "masters", "mastering", "mastered", etc.

rachelkang avatar Oct 22 '21 20:10 rachelkang

at the very least, maybe we can have it ignore spaces? so it can underline the base of a word that may have any of these suffixes?

rachelkang avatar Oct 22 '21 20:10 rachelkang

It used to ignore spaces, but then I saw it underline "hang" in the word "changes":

https://github.com/jonathanpeppers/inclusive-code-comments/issues/16

For plurals, maybe it makes sense to just put another entry in the dictionary? I think about the word "masters", someone probably isn't talking about branches, so "mains" wouldn't make sense but "primaries" does.

I also think "mastering" is probably an OK usage? "I am mastering this technique." Let me know what you think.

I think we should aim to give suggestions for the common cases, and we can keep improving things as we go.

jonathanpeppers avatar Oct 22 '21 20:10 jonathanpeppers