Jonathan Peppers

Results 525 comments of Jonathan Peppers

I think we need a device test for `CollectionView` on iOS: 1. Set `ItemsSource` to something 2. Find the underlying `UICollectionViewCell` and/or other MAUI views, save them in a `WeakReference`...

@filipnavara I found this test: https://github.com/dotnet/maui/blob/2b823f8503748f115028e671b4fff9048628c462/src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.cs#L37-L38 It asserts that after a given `CollectionView`'s `ItemsSource` is cleared, the `ObservableCollection` can be GC'd. Does it prove there might not be a problem...

This passes on Windows with dotnet/maui/main, but I wonder if it fails on iOS/Catalyst: ```csharp [Fact] public async Task ClearingItemsSourceDoesNotLeak() { SetupBuilder(); IList logicalChildren = null; WeakReference weakReference = null;...

I think the same Android API 30 keyboard-related tests are failing on main: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7446466&view=ms.vss-test-web.build-test-results-tab

Yes, a `.binlog` would show the actual underlying error from `ILLink`. I don't think we have enough information on a screenshot.

Is it the correct log? It has no errors inside: ![image](https://user-images.githubusercontent.com/840039/223757768-16f77b6f-6ed0-4863-9df7-5885eba957a0.png) You can open these files with the tool at https://msbuildlog.com to view them.

@Woetroer in your log the build succeeded. If it was a failure, the log view automatically searches `$error` (with a dollar sign) and shows the error message. There are no...

We need a `.binlog` with the details about `"Optimizing assemblies for size failed"` inside. Did the problem mysteriously go away?

You don't actually have to build it *with* the `.binlog` viewer, but you can just add `-bl` to any `dotnet build` or `msbuild` command. If you want to try inside...

Let us know and we can reopen, thanks!