Jonathan Peppers

Results 525 comments of Jonathan Peppers

@Ahamed-Ali what is the size difference you see? Is it less than 100kb? If we were working on app size, this doesn't even feel like "low hanging fruit" to me....

@Ahamed-Ali you might be interested in: https://github.com/dotnet/maui/pull/19945 It seems to significantly reduce the amount of IL, from the `dotnet new maui` template: ``` 108544 mauibefore.dll 81920 mauiafter.dll ```

Oh thinking about it more, should `XamlCompilationOptions.Skip` have `[RequiresUnreferencedCode]` on it? So you get trimmer warnings if you use that enum value.

Ok, yeah it kind of makes sense you can't put ILLink attributes on an enum. It's only because we have a custom MSBuild task that rewrites IL -- that makes...

> should we wire integration tests references with darc, so we are always up-to-date? `MSBuild.StructuredLogger` is third party (although Kirill works for MSFT). I would guess that `main` got updated...

If this is green, I think we are OK to merge: ![image](https://github.com/dotnet/maui/assets/840039/9f1d37e2-4da3-45f7-8a7a-5da18d2c6aa6) I am testing how green CI is, in general, at: * https://github.com/dotnet/maui/pull/20387 * https://github.com/dotnet/maui/pull/20388

Having a `Resource.resx` could certainly conflict with the Android `Resource.designer.cs`: https://github.com/Larhei/Maui-Issues/blob/main/StringResourcesBug/StringResourcesBug/Resources/Strings/Resource.resx This is the same as if you created a plain C# `Resource` class yourself with the same namespace. I...

@Larhei can you share a `.binlog` of when it worked (and doesn't now?) https://aka.ms/binlog

I think both .NET 7/8 were `partial`, though: ```powershell > cat .\obj\Debug\net7.0-android\Resource.designer.cs | select -First 25 #pragma warning disable 1591 //------------------------------------------------------------------------------ // // This code was generated by a tool....

Here is the example: https://github.com/Larhei/Maui-Issues/blob/72b0ba302cdaebf1e438318895c1667b02fe7385/StringResourcesBug/StringResourcesBug/Resources/Strings/Resource.Designer.cs#L10C49-L22