Jonathan Hefner

Results 45 issues of Jonathan Hefner

Using Bootstrap from CDN requires an exact version number that is not tied to gem releases. Although historically `Bootstrap::VERSION` has mirrored the official Bootstrap version number, this might not always...

The regexps responsible for converting method calls with blocks did not account for arguments split across multiple lines. This patch enables multi-line method arguments, as long as every line except...

When converting [passwords/edit.html.erb](https://github.com/thoughtbot/clearance/blob/master/app/views/passwords/edit.html.erb) of the [Clearance](https://github.com/thoughtbot/clearance) gem, the following snippet... ``` ``` ...Is converted to: ``` = form_for :password_reset, - url: user_password_path(@user, token: @user.confirmation_token), - html: { method: :put }...

Currently, `Rails.application.message_verifier(name)` returns a `MessageVerifier` instance using a secret derived from the given `name`. Instances created this way always generate messages using the default options for `MessageVerifier.new`. Also, if there...

activesupport
railties

Follow-up to #40379, #42524, and #43445. The logic to associate records with a `CollectionAssociation` when using `has_many` inversing has become increasingly complex. Prior to this commit, we defined an "add...

activerecord

This adds a `Rails.application.deprecators` method that returns an enhanced collection of deprecators. Individual deprecators can be stored and retrieved from the collection: ```ruby Rails.application.deprecators[:my_gem] = ActiveSupport::Deprecation.new("2.0", "MyGem") Rails.application.deprecators[:other_gem] = ActiveSupport::Deprecation.new("3.0",...

activesupport
railties

1f150f6bc3194f803b15c400513f07aacf53939b made it so that default values are always persisted. This commit adds support for aliased attributes to that change.

@eregon Continuing from https://github.com/rails/sdoc/pull/314#issuecomment-1744589304... Here is a reproduction stripped down from https://github.com/rails/sdoc/pull/314: ```ruby require "erb" def render(template_string) ERB.new(template_string).result(binding) end render("") { "x" } ``` The [original test failure](https://github.com/rails/sdoc/actions/runs/6344362301/job/17234280885?pr=314#step:4:12) (before I...

compatibility

This PR _looks_ larger than it is because this project currently has no testing infrastructure. The majority of LOC in this PR are from `Gemfile` and `Gemfile.lock` files. I have...

This PR _looks_ large because this project currently has no testing infrastructure. The vast majority of LOC in this PR are from `Gemfile` and `Gemfile.lock` files. I have split the...