ansiwrap icon indicating copy to clipboard operation
ansiwrap copied to clipboard

Fix tests on Python 3.11 (fix #18)

Open musicinmybrain opened this issue 3 years ago • 2 comments

random.sample() population must be a sequence

musicinmybrain avatar Jun 20 '22 13:06 musicinmybrain

I guess list() here should be enough as we don't need a sorted sequence?

felixonmars avatar Apr 10 '23 14:04 felixonmars

I guess list() here should be enough as we don't need a sorted sequence?

Yeah, that should be fine, since we don’t care about the actual order of the set or require a reproducible pseudorandom sample for this test. It doesn’t matter much, since the sort doesn’t have a significant cost in test runtime, but I’ll force-push with your suggested change.

musicinmybrain avatar Apr 10 '23 17:04 musicinmybrain