Jonathan Creamer

Results 10 comments of Jonathan Creamer

It looks like it failed in a node 8 test. Should that even be a thing now that 8 is not even in maintenance mode anymore? ![](https://d.pr/i/Fz6OLJ+) This PR would...

Ideally if you're going to be doing conventional commits, each commit with show up as an entry in the CHANGELOG.md.

And if you don't want a particular commit to show up, then yeah you'd commit `-n`.

One of the main benefits of conventional commits is to use https://github.com/conventional-changelog/standard-version, which generates a CHANGELOG.md, and does automatic package.json version bumps.

This is a nice post about `standard-version` http://devboosts.com/2017/03/28/conventional-commits/, and an output automatic CHANGELOG.md example... https://github.com/lonelyplanet/backpack-ui/blob/master/CHANGELOG.md.

That's one possible scenario yea.

I really wanna get this merged. My build just failed on an eslint check because of this... ![](https://d.pr/i/PDMp88+) 😂

Should we just change it to a warning so it won't break builds for now? @Golodhros

Then maybe we should just remove the rule altogether. Enable it locally to do the fixes, then re-enable it once we get it all sorted out?

It seems like the people who want it change, REALLY want it changed vs the people who are all "meh". Haha. To me it just comes down to common practice...