containers-theme icon indicating copy to clipboard operation
containers-theme copied to clipboard

Firefox Bug 1401924 is Fixed

Open jmcs opened this issue 7 years ago • 12 comments

Theme transparency shows hidden icons and another related bug are marked as fixed, so according to the README it should be possible to make the themes less bright.

jmcs avatar Nov 16 '17 10:11 jmcs

That bug shouldn't even matter. Why not just map the colors to the pastel versions? After all, users can't customize the container colors. It's a predefined list.

RuiNtD avatar Feb 02 '18 00:02 RuiNtD

Any news?

syldub69 avatar Mar 01 '18 10:03 syldub69

Ping. Any update possible?

Gitoffthelawn avatar Feb 18 '20 09:02 Gitoffthelawn

@Gitoffthelawn to get around transparency issue, color too bright and dark theme support, I created a pretty simple dark color toolbar plugin long time ago. you should try it : https://addons.mozilla.org/en-US/firefox/addon/container-color-toolbar/

n0rad avatar Feb 18 '20 10:02 n0rad

@n0rad Thank you so much for mentioning your extension. I tried it when you first released it, but I didn't keep it for some reason. IIRC, it was because it didn't theme the horizontal area around the tabs.

Yesterday, I finished writing custom CSS (userChrome.css) to possibly (likely) replace Containers Theme, and I didn't apply any coloring to that area, and so far, I actually like it that way.

I'll definitely keep your extension in mind. Thanks again for mentioning it.

Gitoffthelawn avatar Feb 19 '20 11:02 Gitoffthelawn

I'm happy to accept patches here but I don't even use the extension myself any more.

jonathanKingston avatar Feb 19 '20 11:02 jonathanKingston

@jonathanKingston Thanks for the info! Out of curiosity, why don't you use your extension anymore?

Gitoffthelawn avatar Feb 19 '20 22:02 Gitoffthelawn

I made the extension at Mozilla when there were complaints that the containers were not visible enough. I also made it as a demo what could be done with the APIs we added into the browser. I never really liked the extension and just preferred the defaults.

However as I mentioned, I'm happy to accept PRs to add functionality if people are still wanting it etc.

jonathanKingston avatar Feb 20 '20 00:02 jonathanKingston

@jonathanKingston Thanks Jonathan! Overall, I like the idea of this extension.

However, what I would really like is to be able to visually discern which tabs are in the same container as the current tab. Once all colors are used up (and there are only 9 of them available), there is currently no way to tell at a glance which tabs are in the current container.

@n0rad Is your extension able to do that?

Gitoffthelawn avatar Feb 20 '20 09:02 Gitoffthelawn

However, what I would really like is to be able to visually discern which tabs are in the same container as the current tab. Once all colors are used up (and there are only 9 of them available), there is currently no way to tell at a glance which tabs are in the current container.

This is another reason I don't use it. All the background tabs can be changed to their default colour which would at least add the highlight back. However that was partly the reason people liked this, they didn't like the noise of the underline.

The firefox API's doesn't let me target specific tabs to be coloured just foreground and background and then I use the current tab to pick the colour to display.

Certainly I would be open to having an option to configure the backgrounded tabs to be off and also the opacity too.

jonathanKingston avatar Feb 20 '20 14:02 jonathanKingston

My extension just put a darker version of the container color to the toolbar based on the current tab.

For my usage, the bright color line under each tab is enough to visually see which tabs are in the same container

n0rad avatar Feb 21 '20 07:02 n0rad

Screenshot at 2020-02-21 08-50-32

n0rad avatar Feb 21 '20 07:02 n0rad