Jonathan Smith
Jonathan Smith
symphony process.php has ``` /** * Returns whether TTY is supported on the current operating system. */ public static function isTtySupported(): bool { static $isTtySupported; return $isTtySupported ??= ('/' ===...
Fails in ``` public function setTty(bool $tty): static { if ('\\' === \DIRECTORY_SEPARATOR && $tty) { throw new RuntimeException('TTY mode is not supported on Windows platform.'); } if ($tty &&...
I've got around it temporarily by commenting out the exception line :-) but obviosuly that's not a sustainable solution
OK I will try to check that. Dumb question: The exception says "TTY mode requires /dev/tty to be read/writable". Is this referring simply to the /dev/tty folder? `ls -la /dev/tty`...
Yes, in runserverCommands, runserver function line 80 `Tty::isTtySupported()` returns TRUE (1) Then `setTty()` is called and in https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/Process/Process.php#L1012 on line 1018 we have `self::isTtySupported()` but this returns FALSE (blank) and...
To answer your second question, in https://github.com/consolidation/site-process/blob/main/src/Util/Tty.php#L16 on line 19 the function `posix_isatty` does exist, so the return is set from calling `posix_isatty(STDIN)` which gives TRUE Is that the difference?...
Hi, I don't know if this will fix your problem, but I modified `site-process/src/Util/Tty.php` changing `return posix_isatty(STDIN)` to `return posix_isatty(STDOUT);` Patch attached, in case you want to try it. [_site_process_tty.patch](https://github.com/drush-ops/drush/files/12617409/_site_process_tty.patch)
Ready for review.
You've probably realised this, but the failing tests for standards is because the new file `tests/Drupal/good/GoodNamespace.php` is not excluded when checking Coder's own files: ``` tests/*\.(inc|css|js|api\.php|tpl\.php)$ tests/*/(good|bad)\.php$ tests/*/drupal(6|7|8)/*\.php$ ``` The...
Sorry, yes of course. But I've done some learning in the meantime, I wanted to see if we could exclude everything in `/good` _except_ the GoodUnitTest.php but I could not...