getx icon indicating copy to clipboard operation
getx copied to clipboard

Published 20 hours ago • verified publisher icon jonataslaw

camelCase function ambigious

Open sejun2 opened this issue 3 years ago • 1 comments

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

Every PR must update the corresponding documentation in the code, and also the readme in english with the following changes.

Pre-launch Checklist

  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
  • [x] All existing and new tests are passing.

The existing camelCase function is ambigious. It actually means toLowerCamelCase. So I deprecated it and then added [lowerCamelCase, upperCamelCase ] functions. It has backwards compatibility, so I think it'll be ok.

Thanks

sejun2 avatar Jun 15 '22 08:06 sejun2

You're right, the name is completely ambiguous. Thank you very much for your contribution. I will merge this soon

jonataslaw avatar Jun 20 '22 22:06 jonataslaw

You're right, the name is completely ambiguous. Thank you very much for your contribution. I will merge this soon

Is this pr still valid to merge?

sejun2 avatar Jan 09 '23 16:01 sejun2