getx icon indicating copy to clipboard operation
getx copied to clipboard

"GetMaterialApp.theme.pageTransitionsTheme" has no effect

Open Coober-Ding opened this issue 2 years ago • 2 comments

In the "get_transition_mixin.dart"

//  I think the below code should be  "Theme.of(context).pageTransitionsTheme ?? PageTransitionsTheme() .buildTransitions(....)"
return PageTransitionsTheme().buildTransitions( 
    route,
    context,
    iosAnimation,
    secondaryAnimation,
    route.popGesture ?? Get.defaultPopGesture
        ? CupertinoBackGestureDetector<T>(
            gestureWidth: route.gestureWidth?.call(context) ??
                _kBackGestureWidth,
            enabledCallback: () => _isPopGestureEnabled<T>(route),
            onStartPopGesture: () => _startPopGesture<T>(route),
            child: child)
        : child);

Coober-Ding avatar May 07 '22 16:05 Coober-Ding

+1

fairuzmn avatar Jan 22 '24 06:01 fairuzmn

Any progress here? Maybe this should be use at https://github.com/flutter/flutter/issues/132504#issuecomment-2025776552. To support Predictive back gesture in Flutter 3.22.

return MaterialApp(
  theme: ThemeData(
    brightness: Brightness.light,
    pageTransitionsTheme: const PageTransitionsTheme(
      builders: {
        // Use PredictiveBackPageTransitionsBuilder to get the predictive back route transition!
        TargetPlatform.android: PredictiveBackPageTransitionsBuilder(),
      },
    ),
  ),
  home: const MyApp(),
);

Ssiswent avatar May 24 '24 01:05 Ssiswent