fast icon indicating copy to clipboard operation
fast copied to clipboard

Remove ExpressionParser and use the amazing RuboCop::AST::NodePattern

Open jonatas opened this issue 4 years ago • 3 comments

The RuboCop AST is finally isolated into a separated gem and now we don't need to keep the core of the library as NodePattern is pretty much stable and easy to use.

It also validates syntaxes of the expression and had a slightly different behavior on ... operator.

Basically symbols needs explicitly call with :. nil becomes nil? in most part of the cases and the .something? is just something? now ;)

Kudos to @marcandre for extracting it from RoboCop. My first attempt failed and he simply did it 🚀

jonatas avatar May 24 '20 04:05 jonatas

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).
  • 17 fixed issues! 🎉

See more details about this review.

sourcelevel-bot[bot] avatar May 25 '20 12:05 sourcelevel-bot[bot]

@jonatas Do you plan to merge this?

andriy-baran avatar Nov 21 '21 13:11 andriy-baran

Hi @andriy-baran, thank you for showing interest in this! I made it on a weekend and never pushed it again to the upstreaming changes.

I'll not merge it too soon as I need some time to catch up with the latest expression of the rubocop-ast news and guarantee it will be fully compatible. If you have the time to move on, feel free to rebase I'll be happy to review.

jonatas avatar Dec 14 '21 13:12 jonatas