Jonatan Kłosko

Results 340 comments of Jonatan Kłosko

@josevalim that should work, but then we unnecessarily increase the payload on every request to the server, so I'm not convinced we should do that.

> Could we have a very simple encoding schema where we store only key-values as numbers? What do the numbers point to?

I see, basically compressing by hand, but honestly I think that's too brittle. > Or we use the cookie if localhost, which means we don't care about the footprint anyway?...

Oh, the issue was #1282. The error was ``` Slogan: Kernel pid terminated (application_controller) ({application_start_failure,livebook,{{shutdown,{failed_to_start_child,'Elixir.LivebookWeb.Endpoint',{shutdown,{failed_to_start_chil d,{ranch_listener_sup,'Elixir.LivebookWeb.Endpoint.HTTP'},{shutdown,{failed_to_start_child,ranch_acceptors_sup,{listen_error,'Elixir.LivebookWeb.Endpoint.HTTP',eacces}}}}}}},{'Elixir.Live book.Application',start,[normal,[]]}}}) ``` `eacces` indicates more like reserved port, than port taken. I found related...

> Fixed port, and if conflict use a random port? @josevalim we could actually do that, though I think it should only apply to the desktop app. wdyt?

@josevalim I don't think it's a desired behaviour when running from CLI, especially in case of Docker, and starting on a random port would be rather unexpected.

@fahchen what code is the smart cell supposed to generate? Looking at the source I see the generate code does `KinoExcalidraw.SmartCell.new`, but then you implement `Kino.Render` for that struct that...

> The smart cell consists of two parts: data and options, sso I thought the generated code should include both parts for restoration. The smart cell state returned by `to_attrs(ctx)`...

I think to properly support it, it should be added to WCIF and specified on the WCA website, as advancement condition (or something on top).

@cjfreeze the best bet may be to see if the build works on the latest XLA, you can try building with this env var `OPENXLA_GIT_REV=b8bffdaa852ddb5a435d800331e916cc0e52857b`. Note that in order to...