Jonatan Ivanov

Results 418 comments of Jonatan Ivanov

There was: >[shakuzen](https://github.com/shakuzen) modified the milestones: [1.x](https://github.com/micrometer-metrics/micrometer/milestone/37), [1.11 backlog](https://github.com/micrometer-metrics/micrometer/milestone/189) [on Jan 31](https://github.com/micrometer-metrics/micrometer/issues/880#event-8397950650) It's not a guarantee that it will make it to 1.11 but issues like this (`help-wanted` label) are...

Yes, see the comment before yours: https://github.com/micrometer-metrics/micrometer/issues/880#issuecomment-1625381050

We can merge this next week after we released 1.13.0.

Thank you for the issue! We can add this to the docs, do you want to open a PR against the `1.14.x` branch? Other than the section you highlighted, this...

>for this sort of topic, i am a trunk kind of guy, IMO why to bother with older branches, current 15.x could be sufficient? ;) Because of the other users...

Hi @Indresh2410, Thank you for offering your help. We always welcome contributions. In this case, this is a bit more challenging since that method does not exist in every JRE...

Thanks for the issue! I think I can see other ways to do this without the need of making `KafkaMetrics` `pubblic`. But first, let me check if my understanding is...

Thanks for the changes, I think I might have not been clear about this. Before even considering changing anything in Micrometer, I would like to explore the first two (preferred)...

I pinged them on the issue, I rebased your PR, added an extra ctor (we added one in the meantime), some javadoc and polished it. I think we can merge...

>What they say is true, you can hijack the underlying Java Kafka object during the creation. So it's technically possible. But I think that's a very in-elegant solution. This is...