XhprofBundle icon indicating copy to clipboard operation
XhprofBundle copied to clipboard

Add unexpected end of script support

Open JesusTheHun opened this issue 10 years ago • 3 comments

Hello,

I've installed this bundle to figure some memory issues leading to out of memory errors, and I realized that the bundle store the data on kernel response event, which never occurs in case of unexpected end of the script. So here is my small PR, adding support for these cases. What do you think ?

JesusTheHun avatar Apr 15 '15 10:04 JesusTheHun

I don't know how to deal with your tests stuff :/ EDIT : I've locally added the function calls in tests, but since it is in a register_shutdown_function() closure, it fails. I don't think it's supported by prophecy, is it ?

JesusTheHun avatar Apr 15 '15 10:04 JesusTheHun

@JesusTheHun Just add the IsCollecting should be call check to this test test_on_core_request_with_request_query_argument_configured_and_provided

jonaswouters avatar Jul 20 '15 13:07 jonaswouters

I've pushed my local tests, but as you will see, it fails because as I said, the call is contained into a closure.

JesusTheHun avatar Jul 20 '15 13:07 JesusTheHun