runnerup icon indicating copy to clipboard operation
runnerup copied to clipboard

Advanced workout problem

Open khaderaque opened this issue 5 years ago • 1 comments

Hi! I want to create a custom workout like this example: image

I want to have a countdown before an active step, so I selected this options: image

when I start the workout, this is the layout in the recording screen: image

I think that the step that I selected with an arrow shouldn't be in that position, because the active step wasn't stopped by button press, but when the 20s finished. As shown in the first image, after the 20s active step a recovery step starts and is set to stop only when button pressed. This is when the 15s countdown until the next active step should be. Not before. This order matters a lot, because when I stop the recovery step, there's no 15s countdown to the next active step and it starts immediately when I'm still holding the phone.

Is there something I'm missing here or is it a problem that can be fixed? Regards

khaderaque avatar Jul 19 '20 13:07 khaderaque

https://github.com/jonasoreland/runnerup/blob/master/app/src/main/org/runnerup/workout/WorkoutBuilder.java#L634

In workouts active/rest is expected, so the check is for rest only. On line 644, the countdown step is added before the current step, which seem incorrect.

Both of those should probably be changed, but there should be a workaround.

gerhardol avatar Aug 02 '20 22:08 gerhardol