runnerup icon indicating copy to clipboard operation
runnerup copied to clipboard

Final: Preferences updates

Open Uatschitchun opened this issue 4 years ago • 5 comments

Second try for the preference updates. Suggestions from first try https://github.com/jonasoreland/runnerup/pull/1048 added

Uatschitchun avatar Oct 04 '21 09:10 Uatschitchun

I would suggest to "risk" missing translations, as this will hopefully motivates translators to update. German translation had a huge update in transifex and helps understanding settings and usage together with this preference update. Translating the new strings in german is a matter of minutes What about adding a link to https://www.transifex.com/runner-up/runner-up-android/dashboard/ into ABOUT?

diff --git a/app/assets/about.html b/app/assets/about.html
index b6996698..0b221155 100644
--- a/app/assets/about.html
+++ b/app/assets/about.html
@@ -8,6 +8,7 @@
 <p><a href="https://github.com/jonasoreland/runnerup/wiki">RunnerUp wiki</a></p>
 <p><a href="https://github.com/jonasoreland/runnerup/issues">RunnerUp issue list</a></p>
 <p><a href="https://rawgit.com/jonasoreland/runnerup/master/app/assets/changes.html">Release History</a></p>
+<p><a href="https://www.transifex.com/runner-up/runner-up-android/dashboard/">Help translate (Transifex)</a></p>
 
 <h2>3rd party software</h2>

Uatschitchun avatar Oct 04 '21 10:10 Uatschitchun

@gerhardol am going for a run this morning and will test the latest fix regarding cadence.

Uatschitchun avatar Oct 05 '21 06:10 Uatschitchun

Rebased and squashed

Uatschitchun avatar Oct 08 '21 11:10 Uatschitchun

Will this not be part of 2.4.3.1?

Uatschitchun avatar Nov 09 '21 05:11 Uatschitchun

Likely the public release after next. Alfew strings need to be slightly changed, then this need to be pushed to transifex with two weeks or so grace time for translators.

gerhardol avatar Nov 09 '21 06:11 gerhardol

Finally got to cleanup this PR. There were many minor issues that was difficult to comment on, so I pushed changes There will be a few other changes in some private PRs too

The big issue is that the SettingsActivity is deprecated and need to be replaced with fragments,

gerhardol avatar Feb 03 '23 18:02 gerhardol