jonasongg

Results 22 comments of jonasongg

@vvidday @ckcherry23 I added the variable in data() as I'm not too sure what the idiomatic way to define constants in our Vue files are, let me know if I...

@vvidday thanks for pointing this out! a very simple fix for most of these tests would like you suggested to remove the `.should('be.visible')` assertion in the tests, but i'm not...

@sopa301 Thanks for the suggestions! I decided to go with the exist assertion because it's an easier change (and also `.click()` will automatically scroll once the exist assertion passes). I...

@damithc Thanks prof for the feedback! I've made the changes

thanks @sopa301 @ckcherry23! just implemented the changes suggested

@vvidday thanks for the comments! i have implemented some changes to address them

@reposense/active-reviewers-1 This might be fixed with #2086?

@asdfghjkxd Thanks for the review! I originally wanted to see if it was worth performing this change before I changed the cypress tests, but with your review, I'll go ahead...