Jonas Kello

Results 270 comments of Jonas Kello
trafficstars

From my experiments with this the problem is here: https://github.com/antlr/antlr4/blob/dev/runtime/JavaScript/src/antlr4/index.d.ts This code ```ts export * from "./InputStream"; export * from "./FileStream"; export * from "./CharStream"; export * from "./CharStreams"; export...

Actually there are many places where `.js` needs to be added. It seems the antlr4 package is written in javascript and then the typescript types are manually handled by hand-written...

If I have understood correctly the current approach is hand writing the JS and then putting the types on from the outside and trying to have this cover every possible...

> We are already "compiling" (with webpack) for different targets, so not sure migrating to TS would improve things. I can think of a couple of things here: - You...

Not sure what you are referring to but using typescript would not break any combability with any JS runtimes. If we turn it around, what are the arguments to not...

> The exports wouldn't be backwards compatible. I don't follow, could you be more specific? Like the exports of X would not be compatbile with Y? If you are thinking...

I agree that would be the way to test it. Have `tsc` consume each scenario and see if it works. I would add that if `tsc` is used to create...

@seb Since typescript is a strict superset of javascript, the migration could be as easy as just renaming the files from .js to .ts. This way the output will also...

I think it is related to this part of the grammar: ``` oC_Atom : oC_Literal | oC_Parameter | oC_CaseExpression | ( COUNT SP? '(' SP? '*' SP? ')' ) |...