klaus icon indicating copy to clipboard operation
klaus copied to clipboard

[WIP] PoC for a Node.JS backend using nodegit

Open julien-c opened this issue 5 years ago • 1 comments

julien-c avatar Oct 08 '20 12:10 julien-c

Reviewed most of the code and also did some performance tests on my machine. Implementation and performance look very good. libgit2 performance is 1–2 order of magnitudes better than Dulwich performance, apparently.

I added a few minor review comments. I don't think there are any obviously bad implementation choices.

I suggest that you performance monitor as much as possible in production: Some of the history-based views are unbounded (eg. counting number of commits) and may turn out to be too slow. It probably also makes sense to add caching here and there if you have an easy way to do cache invalidation (with the current refresh mechanism the page is essentially static so you could just cache everything).

jonashaag avatar Oct 26 '20 08:10 jonashaag