bjoern icon indicating copy to clipboard operation
bjoern copied to clipboard

enable listening on IPv6

Open toddjcrane opened this issue 8 years ago • 5 comments

small modification to allow listening on IPv6 addresses

toddjcrane avatar Dec 12 '16 06:12 toddjcrane

I still need to write tests for this

toddjcrane avatar Dec 12 '16 06:12 toddjcrane

Hi thanks for the patch. Minor things:

  • how do I listen on all IPv4 interfaces? With your code it's possible to only listen on all IPv6 interfaces if I understand it correctly
  • there's repeated code there that can easily be put into a function or conditional statement

Tests aren't really necessary, just look at all the other test cases, none if them are actual tears, more like examples...

jonashaag avatar Dec 12 '16 10:12 jonashaag

To listen on all IPv4, listen on 0.0.0.0 I thought about it and decided to set the default to listen on IPv6 as listening on all IPv6 will also listen on all IPv4. Also, there was a bit of a (not so) hidden agenda to further IPv6 enable the internet.

I'll make the refactoring changes to eliminate repetitive code and I'll have it up here shortly

toddjcrane avatar Dec 14 '16 05:12 toddjcrane

Can this be confirmed please?

holms avatar Jan 16 '17 07:01 holms

The patch needs some minor refactoring before it can be landed.

jonashaag avatar Jan 16 '17 11:01 jonashaag