github-action-setup-ddev
github-action-setup-ddev copied to clipboard
jonaseberle
Maintainers, ownership, promotion to drud namespace?
Thanks for making me owner and getting @davereid-pfg in there, it's a good idea. In fact it might be a good idea to promote this to drud workspace. I won't be doing anything to it since I don't personally use it, but for the overall stability and future of the repo it's good to have responsible owners.
Would you be up for promoting it to drud? Github is quite good about redirects, I imagine Github Actions is as well...
Not sure about Github Actions redirecting to the correct one, likely we'd need to update existing references, but I'm not 100% certain on that.
+1 to moving under the drud workspace!
I definitely wouldn't want to break anybody. It's easy to test though. Create a different github action, use it somewhere, move it, see if the action still works. If that doesn't work, we could move it, then fork again into jonaseberle, but I don't like that idea at all.
According to https://github.com/github/docs/issues/15575 we should probably just create a new repository and archive the old one.
Note: GitHub will not redirect calls to an action hosted by a renamed repository. Any workflow that uses that action will fail with the error repository not found. Instead, create a new repository and action with the new name and archive the old repository. For more information, see "Archiving repositories."
https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository
It's easy to fork it into drud/gitub-action-setup-ddev, easy then to archive old one. Requires github's intervention to unfork the drud/github-action-setup-ddev then, but they've been responsive in the past.
From an experiment with some necessary workarounds for the reverse proxy this has become pretty trivial and easy to maintain :) So yes, I am happy and feel honored to have it "official"ized. It is so amazing how many platforms DDEV is officially supporting!
What holds me back a bit: The code is more ugly than it needs to be currently. What we have now has been compiled from TypeScript once and smells. It's easy enough to clean it up, though and I can take care of that soonish.
If I understand correctly we could just push it into a new drud/github-action-setup-ddev remote?
So IMHO no fork would be necessary.
git remote remove origin
git remote add origin [email protected]:drud/github-action-setup-ddev.git
git push [origin master]
After that we could push one last README-change here ("We have moved - please use ...") and archive it.
I'll be away from any developer computer for the next week and on holidays in Belgium :)
It's easy to do this... It will work without any problems because Github does a good job on redirects. Retitling to "ddev" namespace.
Can I request to remove @davereid-pfg and add my regular account @davereid as a maintainer? We had some internal changes with enterprise Github and I'm no longer using that account.
Just checking in with the old account as well, I approve adding my regular account as a maintainer before I close this one.
@davereid I've added your new identity ;)
I've still not removed the code smell but never mind.
Shall I go ahead and use this to transfer to the ddev org?
Or would you @rfay rather add a new repository and we do
git remote remove origin
git remote add origin [email protected]:ddev/github-action-setup-ddev.git
git push [origin master]
I think I have to do it; also note that github will handle redirects ok of existing remotes, but it will pester you enough that you sort it out.
@jonaseberle if you're ready to transfer this to the ddev namespace (and keep maintaining it of course) make me an owner if you can. If you can't, I'll give you temporary privileges on the ddev org. Let me know when you're ready. I'm traveling today so may not be available all the time.
FYI I don't think we should transfer as per https://github.com/jonaseberle/github-action-setup-ddev/issues/25#issuecomment-1206747438 - we would break existing action usages.
Invited you both to https://github.com/ddev/github-action-setup-ddev - if you prefer to rename or etc before publicizing, that's fine too.
I would stay with ddev/github-action-setup-ddev if that's fine for all.
@rfay Can you resend the invite to me? It expired. :/
I'm okay with the name as well.
Should I go ahead and mirror all the existing Git code to the new repository?
Code has been mirrored over to https://github.com/ddev/github-action-setup-ddev. I started enabling some branch protection, updating references, enabling Dependabot, etc. I think we can mark this as archived once we get a new release out there, but all the same tags exist there as well so people should be able to switch over seamlessly.
I am going to tag a new release v1.8.0 (minor version raise) in the new repo so that people can start using it.
I think nothing will break if we archive now. It will unpublish the action from the Marketplace but that is a good thing so we can publish it again from the new repo.
Thanks all! Sorry that I have been so unresponsive.
@jonaseberle I think we might need an updated release on this repo with the name rename first.
I discovered the "unpublish from Marketplace" button in this one but I can't publish the new one yet.
https://github.com/ddev/github-action-setup-ddev/releases/edit/v1.8.0 :
I think we can figure that out later. It's really just a marketing thing - any Github repo with an action.yaml can be used as action.