Jonas Eberle

Results 172 comments of Jonas Eberle

Theoretically the layers of containers are also there. But here it is "easier" because `ddev-global-cache` is a volume already. Randy is right and I have been too quick. To do...

I won't bring over all environment into the containers because that is messy. `CI` is also not something I like because it carries no real meaning :) You can use...

I am open to have a ``` ddev config global --web-environment-add="GITHUB_ACTION_DDEV=true" --instrumentation-opt-in=false --omit-containers=dba,ddev-ssh-agent ``` in https://github.com/jonaseberle/github-action-setup-ddev/blob/master/lib/main.js#L68 (untested) In that case we should also mention it in the README.

Nice, it uses `actions/cache` (https://github.com/satackey/action-docker-layer-caching/blob/main/src/LayerCache.ts). Not sure if it kind of forfeits `docker pull` logic by putting restored images in the local store so newer images wouldn't be automatically loaded...

On the other hand, docker already stores images by layers in `/var/lib/docker/image` (default - haven't checked in Github action). Couldn't we just use `actions/cache` on that directory?

With PHP 7.3 it is necessary to escape `-` when used in character classes but not as range. So this is the corrected line: ` $pattern = "/[^a-zA-Z\\d\\s\\-_$quotedReplacement]/u"; `

I think `ddev ssh` should not echo anything about its exit status. We are in this general area of command handling and exit codes I think: https://github.com/drud/ddev/issues/3518 I would be...

@rfay Removing that `Failed to ddev ssh web: exit status XX ` would still be the right thing to do IMHO.

No need for an option IMHO. People should check the exit code properly if they care about it ;)

> A ddev config.local.yml which does not get commited? Yes, that's how it should work already. `./.ddev/.gitignore` contains ``` /config.*.y*ml ``` So you can add for example a `./.ddev/config.db-port.yaml` with...