Jonas Breuer comments

Results 58 comments of


Jonas Breuer

Replacement of Value and Bins with Writable/Readable derive macros

Hey @CMoore-Darwinium, yes. Goal is to directly build structs from the wire and write to it without intermediate steps and as low redundant allocations as possible. In the end, the...

Replacement of Value and Bins with Writable/Readable derive macros

i thought about this too initially. But there are a lot of tricky details with the wire format that might become hard to handle without working in the scope of...

Replacement of Value and Bins with Writable/Readable derive macros

Sounds good. Ill try to read a bit deeper into how serde could be implemented over the next days.

Adding derive macros to parse structs to bins and values

I'm going to improve this one to make it less memory heavy. Did you already start to implement a method for generic input on the value part? Otherwise I would...

Adding derive macros to parse structs to bins and values

The BinWireWriter idea sounds good to me. So the API functions would accept BinWireWriter and BinWireReader Traits as parameters instead of the usual BinMap and Values, but instead we just...

Adding derive macros to parse structs to bins and values

Yes, i think we could use the serde crate and its derive features as a reference. I agree the names are bit too technical. Most Users probably cant do much...

Adding derive macros to parse structs to bins and values

How should we handle structs that cant be parsed by the derive macro or need custom logic? I think the trait function will need the buffer as parameter so in...

Adding derive macros to parse structs to bins and values

I'm thinking about adding a second abstraction layer over the buffer. That could provide "easy" functions for wire writing instead. If we just add the write_bin function to the buffer,...

Adding derive macros to parse structs to bins and values

no, a lot of them are public. The encoder for operations works that way. https://github.com/aerospike/aerospike-client-rust/blob/master/src/commands/buffer.rs#L1366 https://github.com/aerospike/aerospike-client-rust/blob/master/src/operations/mod.rs#LL124C30-L124C30 If we give the user the ability to directly interact with the buffer instance,...

Adding derive macros to parse structs to bins and values

I tested a bit how this could be done. Maybe you want to give some thoughts on it before i continue to implement it everywhere. In this version, i completely...